CNF-26103: Add default case in istiocsr getIssuer to prevent nil-pointer - #463

pkg/controller/istiocsr/deployments.go (1)

499-500: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick win

Add a focused test for the new default branch.

The existing invalid-kind reconciliation test fails earlier in assertIssuerRefExists (lines 238-240), so it does not execute getIssuer’s new error path. Add a direct getIssuer test asserting the returned error and nil object.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@pkg/controller/istiocsr/deployments.go` around lines 499 - 500, Add a focused
unit test for getIssuer that supplies an unsupported issuerRefKind and verifies
it returns a nil issuer object plus the expected “unsupported issuer kind”
error, bypassing assertIssuerRefExists so the default branch is exercised
directly.

pkg/controller/istiocsr/deployments_test.go (1)

1341-1369: 🎯 Functional Correctness | 🔵 Trivial | ⚡ Quick win

Assert the concrete object type for each supported kind.

The test only checks that obj is non-nil. It would pass if both Issuer and ClusterIssuer returned the same object type. Add an expected type to each table entry and assert it after getIssuer.

Proposed test adjustment

 	tests := []struct {
-		name string
-		kind string
+		name         string
+		kind         string
+		expectedType client.Object
 	}{
-		{name: "issuer kind", kind: "Issuer"},
-		{name: "cluster issuer kind", kind: "ClusterIssuer"},
+		{name: "issuer kind", kind: "Issuer", expectedType: &certmanagerv1.Issuer{}},
+		{name: "cluster issuer kind", kind: "ClusterIssuer", expectedType: &certmanagerv1.ClusterIssuer{}},
 	}

Then compare reflect.TypeOf(obj) with reflect.TypeOf(tt.expectedType).

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@pkg/controller/istiocsr/deployments_test.go` around lines 1341 - 1369, Update
TestGetIssuerValidKinds by adding an expected concrete object type to each test
case, using the Issuer type for “Issuer” and ClusterIssuer for “ClusterIssuer”.
After getIssuer returns, compare the returned object’s type with the table
entry’s expected type via reflect.TypeOf, replacing the insufficient nil-only
assertion while preserving the existing error checks.